rht

Results 789 comments of rht

I'm updating the CONTRIBUTING.rst to include this guide: https://github.com/projectmesa/mesa/pull/1298/commits/86b5095f09ae4dc2a954f97def0d9c4f863b1018. You need to run `git config pull.rebase true` in the Mesa Git repo, and the do a `git pull` from the...

Yeah, the .pre-commit-config.yaml (maybe just remove the `language_version`) and CONTRIBUTING.rst are definitely outdated. A PR to fix them would be appreciated!

> As it is not required I removed it. Also stripped slashes from URLPATH and added some doc. I think these changes haven't been pushed to GH?

Yeah, I think they are fine to be moved to `__init__`. But this refactor should be done in a separate PR, so that the PRs remain small and faster to...

I do think the refactor should happen first. It is simpler to pass in urlpath as a Python argument than Bash env.

Previous discussion at #134.

Another alternative is to create a separate `examples` repo, but link it as a submodule inside `projectmesa/mesa`. Known precedent: NetLogo does it, see https://github.com/NetLogo/NetLogo and look at `models` folder. But...

The CI fails because `matplotlib` is not installed. TODO: - inside PyPlotVisualization.py, do a `try import matplotlib`. If this fail raises an error and say that the optional dependency `matplotlib`...

If the 3 TODOs are addressed, then this LGTM.

> The CI fails because `matplotlib` is not installed. TODO: > > * inside PyPlotVisualization.py, do a `try import matplotlib`. If this fail raises an error and say that the...