Roland Grunberg

Results 612 comments of Roland Grunberg

Sounds fine. I can just modify this PR to also call `fireTraceEvent` so its accessible through the API, and temporarily avoid doing the cleanup. That way everything stays mostly the...

I don't think we can conclude that the workspace existing with unsaved changes is always harmful. As an example : I took a simple project (can be invisible or even...

Do you have steps to generate the above error consistently ? I might be able to find another way to catch if it's likely to happen through workspace storage files....

See https://github.com/redhat-developer/vscode-java/pull/3509 .

The binary (generated with graalvm native-image tooling) should generally perform better on initial startup and offer a lower memory footprint. See https://dzone.com/articles/profiling-native-images-in-java for a brief overview. It might be nice...

Thanks for the reference. Feel free to close unless you'd rather track it.

From testing this out, I don't see a major improvement in terms of build time or memory : On quarkus-langchain4j project : Prior to this change, initialization & "service ready"...

I'm pretty confident this will improve things. In particular (prior to this PR), If I attempted to reload the workspace, I would see : ![image](https://github.com/eclipse-jdtls/eclipse.jdt.ls/assets/1417342/1ab60e32-a927-4275-b061-67b9b7a9b51a) Basically a bunch of jobs...

As @testforstephen mentioned in https://github.com/redhat-developer/vscode-java/issues/2471#issuecomment-1139250689, this might be related to the shutdown bug. I filed a bug in vscode-pde where it seemed to corrupt my workspace and prevent a successful...

I think the above logs just match your post from a few days ago. `!MESSAGE The workspace exited with unsaved changes in the previous session; refreshing workspace to recover changes.`...