Ralph Goers

Results 131 comments of Ralph Goers

OK. Got ahead and create the unit test.

What was your solution? I am getting requires for things that aren't specified anywhere and I need to disable it.

This might be a good use case for using [moditect](https://github.com/moditect/moditect) to generate the module-info.java.

I've done extensive work on this with Log4j 2. You don't say what the problem is but in general: 1. The unit tests must be in the same package space...

I tried to apply the patch but when I run the tests 2 tests in log4j-api now fail: ``` [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time...

I was going to apply this but it now has conflicts. Can you please rebase your fork?

You are on the master branch. That requires Java 11 (it may work with later versions as well, I haven't tried). In addition, the build currently only works from the...

Thanks. This is my fault. I applied a PR that was targeted to the release-2.x branch to master and forgot to change the version when I did. I would have...

To test environment variables in JUnit you can do something like: ``` @Rule public final EnvironmentVariables environmentVariables = new EnvironmentVariables(); @Before public void setUp() throws Exception { environmentVariables.set("NC_PORT", NC_PORT); }...

@garydgregory What is happening with this PR?