Roberto Gomes, PhD

Results 9 comments of Roberto Gomes, PhD

> made some comments in examples/generate_strategies.ipynb. I realize now this is difficult to view in GitHub. Might be easier to view/comment on Jupyter notebook I took a look at Jupyter....

> So your suggestion is to make a separate directory called api/ inside optionlab/ with a yfinance.py module, with the thought being that eventually we will add more APIs? This...

> same as title How have you installed it? Using pip?

After extensive test, the issue could not be reproduced. I need more details.

It seems this problem has to do with Pydantic version >= 2.9: https://github.com/koxudaxi/datamodel-code-generator/issues/1937 It works with Pydantic 2.8.2.

Line 206 in models.py: strategy: list[Strategy] = Field(..., min_length=1, discriminator="type") This is the line that generates the error above for Pydantic >= 2.9.

Reviewing the PR soon.

> Current price increment is 0.01 and hard-coded. it causes making many x, y points in some circumstances. > > Making this value dynamic and adjustable is helpful specially in...