Vadim comments

Results 7 comments of


                                            Vadim

Performance Improvements (similiar ng-bullet)

@ahnpnl I know the `ng-bullet` approach, and it is not good. The idea is to prevent TestBed cleanup and recompilation. It can eventually lead to sporadic issues with unit tests,...

Error: The process '/usr/bin/git' failed with exit code 128

same here https://github.com/rfprod/nx-ng-starter/runs/2593668512 however, premerge was successful just recently https://github.com/rfprod/nx-ng-starter/runs/2593478731

test(unit): update unit test setup, revise existing unit tests

@arturovt does [this change](https://github.com/ngxs/store/pull/1846/commits/9cf11a4ac68a940f1e0920581748b7c46b9f25ac) look good?

test(unit): update unit test setup, revise existing unit tests

> I will have a look at the CI settings. Don't have my dev machine at the moment, but will check the guthub/circleci settings. @markwhitfeld what do you think of...

test(unit): update unit test setup, revise existing unit tests

> @rfprod Could you rebase this on master? @markwhitfeld rebased

test(unit): update unit test setup, revise existing unit tests

> ## BundleMon > Groups updated (2) > Status Path Size Limits > @ngxs/store(umd)[gzip] > ./bundles/*.umd.js > 43.87KB (+1.4KB **+3.3%**) +1% > @ngxs/store(umd.min)[gzip] > ./bundles/*.umd.min.js > 12.71KB (-1.27KB -9.1%) +1%...

test(unit): update unit test setup, revise existing unit tests

> Ah, it all makes sense now, the reason why we have been having issues with jest in the integration apps is because the integration apps are borrowing the version...