Riadh Fezzani

Btw, irony is not what I call super friendly either ;-)

Thank you @jni for this good summary. > - leave things as is more or less I am not in favor of this option, since it leaves this issue unfixed......

I think that it is necessary to rethink `star` and `octagon` argument names (respectively `a` and `(m, n)`): you may be agree that it is not really descriptive...

Even if `rectangle` is with no doubt a useful selem, I think that it can be replaced without much hurt for the user by `np.ones`. I am +1 for the...

> radius implies the thing fits into a sphere. That's not always the case for selems. Damn, only `octagon` doesn't always fit in a circle... :smile:

The problem with the `skimage` current use of even selem shapes is that the behavior is not explicit and that the user have no control on it! I think that...

I tested it, works fine! Thank you for this contribution. Hope that it will be merged soon.

This is fixed by #177 , I hope it will be merged soon ;-).

Thank you @farindk for your answer. > But this is something that may be added in the future. That would be a great addition :slightly_smiling_face: that may ease the adoption...

Thank you @kwikwag for this report. It is an extension of #3122. I refactored your script to take into account two more parameters input and output dtypes: Code here ```python...