Robin Fernandes issues

Results 24 issues of


                                            Robin Fernandes

Cache IPAdapter instances to avoid expensive KV extraction on every generation

Hi all, I'm not deeply familiar with the code I've touched here, so I'm very open to feedback on this PR. ## Description Currently `apply_ipadapter` reconstructs an `IPAdapter` instance on...

Precedence bug with if expressions

`if true 10 else 5/2` evaluates as `(if true 10 else 5)/2`, instead of `if true 10 else (5/2)` .

Prevent or better handle the case where 2 keyframes have the same frame position.

Currently there's nothing preventing you from having 2 keyframes with the same frame number. This causes errors (with poor error messages) when using some functions like cubic spline. Even without...

Upgrade to wavesurfer 7 and drop the react wrapper

Wavesurfer 7 has some performance improvements so would be a worthwhile upgrade. This would be a good opportunity to drop the react wrapper which isn't helping us that much. This...

Bug: functions that use AST node state (e.g. recompute_if(), rand() with hold) don't work when used in prompts directly because the AST is rebuilt for every frame

Need to either externalise node state or somehow re-use ASTs across prompts/frames.

Integrate with standard Deforum

The A1111 Deforum extension integration is working well, but many users prefer plain old Deforum :) There's no reason we can't do a Parseq integration there too.

Ideas for functions: normalise(), info_match_gap(), frames_since_match("X"), progress_between_matches("X")

Add short cuts for: - `info_match_next("X")-info_match_last("X")`, perhaps called `info_match_gap("X")`? - `f-info_match_last("Beep")`, perhaps called `frames_since_match("X")` . It would then be sensible to add a `frames_until_match("X")` for completeness. - `frames_since_match("X")/info_match_gap("X")` aka `progress_between_matches("X")...

Robin Fernandes