Jonathan Revusky

> I notice the new parser has dropped the constructor which takes a Reader, it monitors for input. > > https://github.com/beanshell/beanshell/blob/5a9d8d8c76408b39d72a130c99ccd9286696dda1/src/main/java/bsh/legacy/Parser.java#L7776-L7805 > > We use it for the REPL client,...

> > And, really, I think that if we commit to this, we can certainly set a realistic goal of throwing away the older parser by the end of this...

> Have a problem, Tokens are not Nodes. =( Well, you need to get rid of the legacy code as soon as possible. Tokens ARE Nodes in CongoCC. Or, to...

> I may also be incorrectly mapping Delimiter, this is not going to be easy. > > ``` > INJECT Delimiter : extends bsh.BSHPrimarySuffix > INJECT AdditiveExpression : extends bsh.BSHBinaryExpression...

> > I've already said that I will do whatever incremental work to get the REPL going. > > YOU DON'T HAVE TO DO THE REPL!!!! Well, in principle, I...

> > Well, Delimiter is a Token subclass, so it can't extend BSHPrimarySuffix, which, I suppose is a BaseNode, i.e. a NonTerminal. If you did need Delimiter and BSHPrimarySuffix to...

> > But, you know, Nick, if you really lack the time to put into this, then that is all the more reason to take to heart some of my...

> The `TOKENS_ARE_NODES=false` is not going to work, Actually, this probably can't work for this case because I think too much of the logic in the Java grammar assumes that...

Well, as I said, there really isn't any reason for a project of this nature to have to implement this (again, I mean on the parsing level). See: https://github.com/javacc21/javacc21/blob/master/examples/java/Java.javacc#L1266-L1297 I...

Well, to be honest, I am not very clear on what benefit there is in having the grammar in this format. (I don't mean to say that in any aggressive...