Revin Guillen

Results 55 comments of Revin Guillen

Currently a WIP; needs to have [a few questions](https://github.com/npm/marky-markdown/issues/363#issuecomment-301577964) answered: >* Our tests explicitly check that `` is allowed when we're executed with `sanitize: false`. Nothing magic about `` in...

@boucher Are you still in a position to test this? We recently removed all of the frontmatter processing code; does that take care of things? marky 6.0.4 and 7.0 have...

@ashleygwilliams sounds cool, would we want them all as one module that gets treated as a single markdown-it plugin? Are you talking about the `packagize` and `cdnImages` stuff, or more?

@ashleygwilliams this one's up to you; it's not really github compat work, but it's also not hard to add to the case where marky's options are overridden with `highlightSyntax: false`,...

Oh this is awesome! Thank you! Yes, with regard to edge cases, I think we're going to need to create some kind of list parsing torture test in test/fixtures/, and...

Hi @jamestautges just checking in now that the holiday season is mostly over. No pressure at all or anything, but I was wondering if you were still planning on trying...

Hey @shibasisp, that was quick! Fantastic! Guess what? I totally forgot to list that we have unit tests around this as well, and for TravisCI to pass the PR, the...

That sounds good. So @shibasisp does that sound interesting to you? Basically add an option in index.js, say, `allowDeprecatedYoutubeEmbeds: false` (unless you have any particular preference for the name, @ashleygwilliams),...

Hey again @shibasisp, do you have the time/availability to implement the version of this where it's deprecated and not removed entirely? If not, I can take over from here if...