Yiming Liu

Results 12 comments of Yiming Liu

比赛要求的syscall有一部分与原xv6中的syscall存在偏差,也有部分是原xv6中syscall的超集。在清洗代码时或许可以考虑精简一下syscall,统一采用比赛要求的syscall。

可以考虑效仿Linux代码的组织形式,将不同功能的代码存入不同的文件夹中,比如使用`driver`文件夹来存放各式各样的硬件驱动程序等等。

I think a good idea is to have `now.format("%s")` returns `Result` instead, but this will change the API... Another solution I think is making `now.format("%s").to_string()` returns an empty `String`, which...

> I have run into this as well, can it be fixed in the next release? thx I wonder if my PR solves your problem? It's made a few months...

To be honest, I don't get to understand your minimal repro codes. What is `ndt` in the code? Is it `naive` that you create by `let naive = NaiveDateTime::from_timestamp_opt(456456456456, 0).unwrap();`?...

> My use-case involves direct user input, where there is no bound on the input outside of the limits of `i64`, and where > I need to be able to...

I think there's something wrong about the coding format, since it doesn't pass the `lint` check. I suggest you run `cargo fmt -- --check --color=always` to see which lines are...

> If invalid, I would imagine this would simply produce "%{whatever}", not > "whatever}" That sounds reasonable. I'll work on it. By the way, I think the idea to introduce...

> Maybe create another function that returns a Result? I roughly created a `try_format` function for this purpose. However, I find that there's many format functions for each structure like...

> Is there some outer API here that's not propagating the error from the inner API, but panicking instead? Yes, it's the panic problem. The original `format` function panics when...