Riccardo Schirone

Results 270 comments of Riccardo Schirone

> @caribpa @ret2libc if the patching cannot be avoided we could employ semantic patching with Coccinelle suite: > > * https://coccinelle.gitlabpages.inria.fr/website/sp.html > > * https://dewaka.com/blog/2020/01/25/semantic-patching/ I'm not sure what coccinnelle...

> @ret2libc why the thumbs down? sob Just because I don't like the approach. And, again, I don't see why coccinelle would really help to do any non-trivial adjustments.

We should really double check whether this is a real bug or not... It might be there are some alignment thing to consider. Also, it might be that this was...

See as well https://github.com/rizinorg/rizin/pull/637#issuecomment-779973443 . RzGraphDrawable was one first initial attempt by @karliss to improve the situation. I agree we should have some better way to deal with all those...

@XVilka can we remove this from 0.3.0? With you being loaded with types issues and me on commands, I think we don't have time in the next weeks/month to work...

I'd move this to idea repo. @XVilka ok?

`@PACKAGE_INIT@` should be used in the `cmake.in` files and meson should replace that with the right `get_filename_component(PACKAGE_PREFIX_DIR_WORKAROUND` and `set_and_check` definitions.

This is probably going to be long term, as even if meson makes a release now we don't want to bump the required version of meson too soon to have...

> Do the calculation dynamically in cmake in the final rz_Config.cmake file - I'm ok with this option.

What's the status of this? Also, the issue references many "problems" and features, so we should be clear what is missing and what not. @XVilka @PulakIIIT