Reshama Shaikh

Results 53 comments of Reshama Shaikh

@jeremiedbb Wondering why `sklearn/linear_model/_glm/glm.py` doesn't appear on this list? Was it covered in this PR ?: https://github.com/scikit-learn/scikit-learn/pull/23491 I had added the `check_scalar` function via this PR: https://github.com/scikit-learn/scikit-learn/pull/21946

I will work on PoissonRegressor, TweedieRegressor and GammaRegressor (note, in `class` GeneralizedLinearRegressor)

> I'm having issues with mypy complaining about a reference to the parameter_constraints of a base class. > > ``` > _parameter_constraints = { > **_BaseDiscreteNB._parameter_constraints, > "norm": ["boolean"], >...

FYI: next scikit-learn Community office hours on Monday, June 27. In case you have questions on your pull requests for this issue. More info here: https://github.com/scikit-learn/scikit-learn/issues/23070

- [ ] sklearn._config.config_context https://github.com/scikit-learn/scikit-learn/pull/21426 - [ ] sklearn.metrics.pairwise.paired_distances https://github.com/scikit-learn/scikit-learn/pull/21440 - [x] sklearn.model_selection._validation.cross_val_predict https://github.com/scikit-learn/scikit-learn/pull/21433 - [x] sklearn.model_selection._validation.cross_val_score cross_val_score https://github.com/scikit-learn/scikit-learn/pull/21464 - [x] sklearn.cluster._agglomerative.linkage_tree https://github.com/scikit-learn/scikit-learn/pull/21424 - [x] sklearn.metrics._regression.max_error https://github.com/scikit-learn/scikit-learn/pull/21420 - [x] sklearn.cluster._kmeans.k_means...

@thomasjpfan After Step 2 and before "removing the function" part, can we add this reminder: 2. Create a feature branch. Example: ``` git checkout -b np_v_has_fit_parameter ```

working on: `sklearn.utils.validation.has_fit_parameter`

@ogrisel I think that's a great idea. Limit to 3 PRs per contributor. This way, they get practice, especially working with more than one branch. And then, with this experience,...

@thomasjpfan Wanted to check, are folks working on 14 items? We have this information up at the top: >Note: once you have issued 3 such PRs, feel free to move...