content icon indicating copy to clipboard operation
content copied to clipboard

Action on tool delete

Open hansioan opened this issue 4 years ago • 1 comments

@bgruening @hmenager @joncison @matuskalas @piotrgithub1

Hi all,

This issue is regarding tool deletion from the ecosystem, especially pull requests coming from outside (e.g. from bio.tools or from forks).

It could be the case that in our content file structure we have something like: data/tool_id/tool_id.biotools.json where this is the only file. If we delete this file then the whole folder goes as well, if this is intended behaviour it's fine but we just have to agree on what happens on delete.

I was thinking of, istead of deleting the file immediately, especially when changes are coming from bio.tools perhaps we can mark tools as deleted by renaming the bio.tools files to something like .deleted.tool_id.biotools.json. In this way the folder doesn't go away.

I think we can code and handle both cases, it's just that we have to agree on what we want the functionality to be. What are your opinions on this? Please tag other people.

hansioan avatar Apr 04 '20 14:04 hansioan

I agree with @piotrgithub1 suggestion that we rename the entry rather than delete it, but keep the .deleted part at the end, i.e. tool_id.biotools.json.deleted In this way the file won't have a .json extension, but a .deleted extension which will separate it from regular .json files.

hansioan avatar Apr 08 '20 14:04 hansioan