Raihaan Shouhell
Raihaan Shouhell
@cpt1gl0 I hope you don't mind, I took the liberty of resolving the simple issues.
This is going to break the node counting. Not sure how to best handle this
https://github.com/jenkinsci/ec2-plugin/blob/dfa60b734c7645cd43060070b9de23268636e9f1/src/main/java/hudson/plugins/ec2/EC2Cloud.java#L606
> What additional changes are needed, if any, for this to be ready for the next release? Something to make it backwards compatible, as is this will break backwards compatibility
Close and open PR should trigger a rebuild
> @res0nance I apologize for the explicit tag, but I want to put this on your radar as I believe it is a significant security improvement (although the change itself...
In what situations does this happen and can this be tested?
A good start to tests is an old testcase that would otherwise timeout should not timeout any longer.
This seems to come with the problem that it would increase the time it takes for the node to connect by a large amount
Could you add a test for this?