ec2-plugin inclusive language tags: jenkins_slave_type renamed to jenkins_node

I know there are many other master/slave references. This one will only correct the issue with jenkins ec2 worker tags.

This is also consistent with Jenkins using the word node for their workers.

Ref: https://tools.ietf.org/id/draft-knodel-terminology-02.html

Ticket: https://issues.jenkins-ci.org/browse/JENKINS-63660

Sep 16 '20 21:09 nitrocode

Hi @fcojfernandez @res0nance @MRamonLeon

What are some of the thoughts on this ?

Sep 23 '20 15:09 nitrocode

This is going to break the node counting. Not sure how to best handle this

Sep 23 '20 15:09 res0nance

Where is node counting codified?

Sep 24 '20 02:09 nitrocode

https://github.com/jenkinsci/ec2-plugin/blob/dfa60b734c7645cd43060070b9de23268636e9f1/src/main/java/hudson/plugins/ec2/EC2Cloud.java#L606

Sep 28 '20 12:09 res0nance

Thanks. It sounds like it might be best to have logic to count both the jenkins_slave_type and jenkins_node_type tag names but tag the latter going forward for newly created instances. For the getGenericFilters, we could count both tag names. I'll put in some more work.

Relevant code references (for myself):

https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/ec2/model/Filter.html
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/ec2/model/Tag.html

Sep 28 '20 14:09 nitrocode

What additional changes are needed, if any, for this to be ready for the next release?

Apr 05 '22 21:04 dannykansas

What additional changes are needed, if any, for this to be ready for the next release?

Something to make it backwards compatible, as is this will break backwards compatibility

Apr 06 '22 12:04 res0nance

inclusive language tags: jenkins_slave_type renamed to jenkins_node_type