Renuka Piyumal Fernando

@alecholmez could you please review this?

Hi @alecholmez, What do you think is the best? Using ADS or having a separate RLS config service? I removed the RLS config service and commit https://github.com/envoyproxy/go-control-plane/pull/598/commits/d0a39a043e3bfaf89934ad6bf8eb5c2e35f2860a to this PR

Is there an xDS client for ADS that can be reused in the rate limit? So I do not want to implement an xDS client in the rate limit repo,...

Hi @abhi93104 Did you try, the "Replace" feature? Feature: https://github.com/envoyproxy/ratelimit/tree/0b2f4d5fb04bf55e1873e2c5e2bb28da67c0643f#replaces Example: https://github.com/envoyproxy/ratelimit/tree/0b2f4d5fb04bf55e1873e2c5e2bb28da67c0643f#example-7 Could you check with the following rate limit configuration? ```yaml descriptors: - key: remote_address value: 182.156.218.11 rate_limit: unlimited:...

In your case, both limits are getting applied, i.e. both unlimited and 5 per sec. When multiple limits are applied, the policy that denies the request will always win.

The issue was not reproduced after the fix https://github.com/wso2/product-microgateway/pull/2964

This is the same behaviour with the Synapse gateway (APIM 4.2.0-alpha)

The rate limit value depends on the query made (Operation count). For the following query, it is rate limited after 20 requests (Both CC and APIM Synapse GW). ``` {...

Following are the results for the following query. ``` { human(id: 1000) { id name } droid(id: 2000) { name friends { name appearsIn } } } ``` ### Subscription...

It looks like not an issue. App and Sub level rate limit depends on the operation count of the request, but keeping the API level rate limit not depends on...