go-control-plane icon indicating copy to clipboard operation
go-control-plane copied to clipboard

Add Rate-Limit xDS config server related control plane functionality

Open renuka-fernando opened this issue 2 years ago • 1 comments

Related issue

Fix envoyproxy/go-control-plane#595

Proto files

PR: https://github.com/envoyproxy/ratelimit/pull/368

Description

To configure envoy rate limit service via xDS

renuka-fernando avatar Oct 13 '22 12:10 renuka-fernando

@alecholmez could you please review this?

renuka-fernando avatar Oct 13 '22 15:10 renuka-fernando

Hi @alecholmez,

What do you think is the best? Using ADS or having a separate RLS config service? I removed the RLS config service and commit https://github.com/envoyproxy/go-control-plane/pull/598/commits/d0a39a043e3bfaf89934ad6bf8eb5c2e35f2860a to this PR

renuka-fernando avatar Oct 18 '22 16:10 renuka-fernando

Is there an xDS client for ADS that can be reused in the rate limit? So I do not want to implement an xDS client in the rate limit repo, just import from go-control-plane and use it.

renuka-fernando avatar Oct 19 '22 03:10 renuka-fernando

Sorry for the slow response times! I'll begin to look into this.

I would actually like us to have RLS over ADS. That's the most common use case and if people begin to request that we supported a separated RLS service we can address that down the line.

alecholmez avatar Oct 28 '22 14:10 alecholmez

please include this for java control plane too.

kkcmadhu avatar Dec 16 '22 17:12 kkcmadhu

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jan 17 '23 12:01 github-actions[bot]

Hi @alecholmez,

Could you please run the failed build again and please review the PR? The issue with the build is fixed now: https://github.com/envoyproxy/go-control-plane/issues/625

renuka-fernando avatar Jan 27 '23 01:01 renuka-fernando

@alecholmez, thank you very much for the support in getting this done.

renuka-fernando avatar Jan 27 '23 15:01 renuka-fernando