Tom Rothamel
Tom Rothamel
I'm looking through this, and I'm seeing a lot of reformatting files to styles I find ugly, like wrapping lines too short, and adding things like: https://github.com/renpy/renpy/pull/6216/files#diff-31a458f21cbb822ea0442ed6ce25a4c8236cd1db96a3b03b274681996e42387fR58 Which isn't something...
Yes on using black, though I need to figure out what I want the line length to be. I've been playing around with 120. I'm leaning on doing a massive...
Scheduled to go in when I get some time to review it.
Question about this - did you write the types yourself, was this generated with a tool, or something else? Part of this is trying to figure out the right way...
Were you able to run this, especially on Python 3.12? I'm noticing a number of errors, ranging from undefined types being used to syntax errors, like: https://github.com/renpy/renpy/pull/6216/files#diff-220e3cc26db85b053ce4e42e2b8a45d825782497cb198d12a9f50aef3f5f48adR320
I'd suggest waiting on that. We're putting together some guidelines as to how Ren'Py typing should work, as we need a typing scheme that can last for a long time....
This won't work, because you can't import variables from other modules in the same way you can import functions. That means we'd have to change renpy.config.`whatever` to renpy.config.`module`.`whatever`, which feels...
Perhaps following the structure of config.rst is the way to go? I don't think the length of the file is the issue, as it tends to be very simple structurally....
I'd be fine with tags (unused: and compat: ). I think I could live with the variables being included into config.rst, if you want to do the heavy lifting of...
This already exists - you just customize the confirm screen for the particular message.