Kun Ren

Results 365 comments of Kun Ren

I'll find a time to submit to CRAN recently. Thanks for your reporting!

It looks really interesting and can be helpful to make it work in pdf. Thanks!

Would you like to provide an example where other htmlwidget works with promises?

I'll take a closer look at this soon.

A bit off the topic. @krlmlr Please feel free to add yourself as a contributor to `DESCRIPTION` to reflect your active participation of the package. Thanks!

One thing to notice is that the class name is bit too long for printing: ``` > library(formattable) > library(data.table) > library(tibble) > p p id name balance growth ready...

> We could also add `pillar_shaft()` and `type_sum()` methods, perhaps as a separate PR? A separate PR makes good sense.

It works fine with light RStudio theme like TextMate: ![formattable-htmlwidget-r-notebook2](https://cloud.githubusercontent.com/assets/4662568/15797271/4eee2d94-2a44-11e6-88ef-4be390aea8b8.png)

Posted an issue at RStudio: https://support.rstudio.com/hc/en-us/community/posts/211637527-The-text-color-of-htmlwidget-can-be-too-light-in-R-notebook-under-dark-themes

I've considered this indeed but haven't come up with a way to do this even with basic `plot`. I'll try more.