XlsxReaderWriter icon indicating copy to clipboard operation
XlsxReaderWriter copied to clipboard

fixed broken XMLDictionary.h import

Open mheicke opened this issue 8 years ago • 3 comments

fix for broken PR: https://github.com/renebigot/XlsxReaderWriter/pull/36

mheicke avatar Aug 12 '16 16:08 mheicke

not sure who quick how quick @dphov will respond, so I just fixed it by myself (since it's only a couple of changed imports)

mheicke avatar Aug 12 '16 16:08 mheicke

Hey this might be super late but I found an alternate solution to this problem. Adding XMLDictionary/XMLDictionary.h causes an Include of non-modular header inside framework module error when you archive the project.

I solve this by adding XMLDictionary.h to the public headers of XlsxReaderWriter in Build Phases and leaving import "XMLDictionary.h" alone. This solves this issue and the non-modular header issue.

I hope this helps someone.

my question with my answer on stack overflow: https://stackoverflow.com/a/59492076/3749869

DannyEspina avatar Dec 26 '19 18:12 DannyEspina

I fork the repo and support Framework, and much mor if you are interested. FYI. XMLDictionary has been abandoned, so I removed the dependency and integrated it directly in the project.

https://github.com/charlymr/XlsxReaderWriter

charlymr avatar Dec 28 '19 10:12 charlymr