Rene de Souza Pinto
Rene de Souza Pinto
> If a single PR changes too many files there will be an issue to generate/apply patch and Yetus will complain, we see this a lot for PRs updating vendor...
> @christoph-zededa I guess #5228 can be closed then in favor of this one ok, feel free to close it then.
converted to Draft because zizmor doesn't like me :cry: I'll try to fix the complains... @shjala , shall we merge only after a full pass? :smile:
@rucoder , regarding the tag. I put it in the action as a variable so it can be easily changed. Here, it does make sense to keep as latest because...
@rucoder , please, see the TAG version, as we discussed...
reviewers, I think I've addressed all issues, this PR is ready for review....
@eriknordmark , @rucoder and other reviewers, it's been 3 weeks since this PR is ready, I've addressed all comments. Appreciate your final approval....
> > Isn't riscv64 missing? > > > > > You can follow this pattern > > > > > > I don't think it is a good idea to...
@shjala tests/semgrep-rules/os-openfile-non-perm-mode.yaml is missing Copyright note. Please, once we merge it, don't forget to open the PR updating vendor files.... in all dependencies (pkg/edgeview, etc).
No tested yet. Need to test.