eve icon indicating copy to clipboard operation
eve copied to clipboard

Build yetus image on demand

Open rene opened this issue 1 month ago • 6 comments

Description

This PR introduces two things:

  1. The source code for the Yetus image we are using in our GH actions
  2. A new GH workflow to build and push this image on demand

Since we don't update Yetus image very often, the idea is to provide the action to build it only when some update is needed. By using this approach we don't need to keep a new/separated repository (e.g. lf-edge/eve-yetus) only for this image.

The version (TAG) is marked as the following:

0.15.1-eve-1

where:

0.15.1 (Yetus base image version) + eve-1 (represents the version of our image, future images will be eve-2, eve-3, etc)

How to test and validate this PR

Run the workflow manually (since it runs on demand) and check that it works.

PS: This PR was tested on my repo: https://github.com/rene/eve/actions/runs/19572770766/job/56050134859

Images for amd64 + arm64 are published.

Changelog notes

No user-facing changes.

PR Backports

The Yetus image is the same across the other branches (in their actions), so there is no need to backport this PR.

Checklist

  • [x] I've provided a proper description
  • [x] I've added the proper documentation
  • [ ] I've tested my PR on amd64 device
  • [ ] I've tested my PR on arm64 device
  • [x] I've written the test verification instructions
  • [x] I've set the proper labels to this PR
  • [x] I've checked the boxes above, or I've provided a good reason why I didn't check them.

rene avatar Nov 12 '25 17:11 rene

converted to Draft because zizmor doesn't like me :cry: I'll try to fix the complains... @shjala , shall we merge only after a full pass? :smile:

rene avatar Nov 12 '25 18:11 rene

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 28.08%. Comparing base (2281599) to head (2833575). :warning: Report is 107 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5399      +/-   ##
==========================================
+ Coverage   19.52%   28.08%   +8.55%     
==========================================
  Files          19       19              
  Lines        3021     2314     -707     
==========================================
+ Hits          590      650      +60     
+ Misses       2310     1520     -790     
- Partials      121      144      +23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 12 '25 18:11 codecov[bot]

@rucoder , regarding the tag. I put it in the action as a variable so it can be easily changed. Here, it does make sense to keep as latest because this action will build a fresh Yetus custom image. However, it's important to point out that the TAG (version) used in our actions is defined by the test-patch-action: https://github.com/lf-edge/eve/blob/master/.github/workflows/yetus.yml#L32

So here I'm just building the image, my idea is to move the test-patch-action to inside our repo, but this will be handled by a future PR.

rene avatar Nov 13 '25 12:11 rene

@rucoder , please, see the TAG version, as we discussed...

rene avatar Nov 21 '25 14:11 rene

reviewers, I think I've addressed all issues, this PR is ready for review....

rene avatar Nov 21 '25 14:11 rene

@eriknordmark , @rucoder and other reviewers, it's been 3 weeks since this PR is ready, I've addressed all comments. Appreciate your final approval....

rene avatar Dec 13 '25 18:12 rene