René Fonseca

General feedback on integrating a library

3

Hi team, I spend a few days integrating my library with jupyter/xeus/cling. And put together some feedback on the various issues that came up. I do like what you have...

signal header C++/WASI libc inconsistency (WASI SDK 8)

1

There is an inconsistency in the signal headers for C++ vs C lib that causes build failure. Tested for WASI SDK 8. Error from compiler: `/usr/local/wasi-sdk/share/wasi-sysroot/include/c++/v1/csignal:53:9: error: no member named...

[examples] Should check import types

7

The **wasm_instance_new** C-API implementation fails due to buffer overrun for the imports buffer. The imports argument doesn't have a size. https://github.com/WebAssembly/wasm-c-api/blob/b0b4bfb032af537fa747a505eba222eb1e35edd9/src/wasm-c.cc#L995-L1006 Since there is no size given as argument, it...