rene

Results 78 comments of rene

We haven't seen this in a while, reopen if seen again.

Meh we can just implement the same 128 headers max per message on the serving side.

> @renaynay, Currently, we request 128 headers, but the responding side doesn't have a check for max headers, so that's DOS vector. Luckily it is just a one if to...

> Request size configuration for clients and servers. Servers should tell the number of headers they can serve with the hello msg. I think this should be an optimisation for...

We still need to turn all TODOs in the comment into issues to make this a tracking issue

> > raud proof request loop does not guarantee to ask 5 different peers for frauds, it only asks 5 times > > We don't have a check for that....

> > why was this resolved? What is this error check even doing? > > It was left by mistake after resolving all merge conflicts. Will remove it Okay as...

Do we still want to do this @Wondertan ? https://github.com/celestiaorg/celestia-node/pull/506#issuecomment-1103839573