Nathan Reline

> Overall looks good to me, the real question to me though is if we should set the charset in the builder up front or read the XML declaration encoding...

@sockeqwe I'd actually be interested in implementing this feature, I'll be doing it regardless in a fork for my use case [here](https://github.com/reline/Jisho/blob/701c2e0cd48f4d5ced64b0b86e16f22d86e982f3/hello.xml) but it would be nice to have some...

@qLag It is possible, Okio's API allows you to provide a charset with [Buffer#readString()](https://square.github.io/okio/2.x/okio/okio/-buffer/read-string/), [Buffer#writeString()](https://square.github.io/okio/2.x/okio/okio/-buffer/write-string/), and [ByteString#encodeString()](https://square.github.io/okio/2.x/okio/okio/-byte-string/-companion/encode/) I think the only issue is skipping the leading BOM for each charset....

I made a draft here #150, needs unit tests but I went ahead and started the leg work.

@qLag In the meantime you can always build a snapshot off of that branch if it's urgent and meets your needs. I'd like to get more feedback from the maintainers...

@qLag Glad that worked for you! I updated the PR with some unit tests, only significant difference I made was fixing the XML declaration when writing in charsets other than...

This isn't implemented yet, as I don't have a lot of spare time, but it is on the roadmap.

Any update on this? I also found this vulnerability in my Fortify scan results. The PR has been open for quite some time.

Sorry to bring this back to life if this is the wrong place for this, but I was experiencing the same issue but strictly with a Flutter Plugin project only....

CircleCI doesn't look like it supports badges for code coverage, but we still at least want code coverage reporting outputs. https://github.com/circleci/circleci-docs/issues/1802