Rolf Erik Lekang

Results 33 comments of Rolf Erik Lekang

This seems weird, maybe the input to pillow should be different for jpg and png? 🤔

@martinmaillard Thanks for the input. What did you have in mind? What about putting the raw data from the image engine in `thumbnail.data` when a flag is sent to `get_thumbnail`.

Wand is already supported :) Do you have any examples that show that ImageMagick has better quality than GraphicsMagick? I guess both could be supported.

Nice catch, this is most definitively a bug. I think I found the source: [The Thumbnail model has hardcoded jpg as extension](https://github.com/python-thumbnails/python-thumbnails/blob/master/thumbnails/images.py#L34). Do you want to look into fixing it?

I think I figured something out, a most of the code for detecting image format was already in place but never called. I added extension as a required argument to...

The last commit on this project was three years ago, so I would guess it needs a bit of work to be compatible with current versions of python and django....

I think it would be really awesome if we could do something like the following. ```es6 import { adapterTestSuite } from 'micro-analytics' // or some other package that is published...

Cool, looks good 🎉

Looks like the docs and implementation is the same. The implementation sends this as options. ```js { pathname: pathname, before: parseInt(query.before, 10), after: parseInt(query.after, 10), } ```

Yeah, that means that the spec differs from the implementation of micro-analytics-cli. If you follow the spec it will not work as expected, but if you follow the tests it...