Yevhen Sidelnyk
Yevhen Sidelnyk
Yes, to move with this I need to understand your vision and how you anticipate this.
@greg0ire , Hi, could you please respond?
Where do you expect iterable of files to be passed in?
@greg0ire , hi! regarding iterable files approach, do you expect finder to be passed in as `$paths`? That's how ORM driver uses it: ```php class AttributeDriver implements MappingDriver { use...
@greg0ire , how do you expect iterable to be given?
So, as I understand, we should: 1. change `protected array $paths` (`string[]`) into `protected iterable $files` (`SplFileInfo[]`); 2. delete `addPaths(array $paths)` method as it expects `array $paths`, which is not...
Right now doctrine/orm driver constructor method signature looks like this: ```php public function __construct(array $paths, bool $reportFieldsWhereDeclared = true) ``` We could probably change `array $paths` to `iterable $files`, and...
> boolean as a third argument to this Will it be any better than the suggested approach? I presume it's possible that you didn't fully get what I intended to...
Why should we allow passing the file names?
> Well @derrabus 's suggestion is to pass an iterable of files, right? Yes, that's right: > If we want to open this up for more complex cases, we could...