Markus Reiter

Results 208 comments of Markus Reiter

> Feels a bit weird to have `1` be one of these options We can call it `true` or `always` if that makes it less weird, but the code currently...

> If the behaviour of multiple at the same time is well defined and supported That's actually a good question. I don't think it is well defined and more of...

> Yeah, it is. Okay, if it wasn't, separate variables would make sense to me. Given that it *is* equivalent, one variable makes more sense to me.

> I think following the flags and having three variables makes sense to me. Personally, I think it would actually make more sense for the flags to be `--greedy`, `--greedy...

Given we already have `HOMEBREW_UPGRADE_GREEDY`, I think it would be better to support `HOMEBREW_UPGRADE_GREEDY=auto-updates` or `HOMEBREW_UPGRADE_GREEDY_AUTO_UPDATES` as you already mentioned. Also, I think we should deprecate `HOMEBREW_CASK_OPTS` at some point...

Let's modify `HOMEBREW_UPGRADE_GREEDY` to allow `auto-updates`. This way also only one of the options can be set at a time.

> not sure that it's intuitive to include and extend the same module I disagree, that's just how Ruby works, but it is actually quite surprising that **all** existing usages...

> restrict this to methods without arguments with `method.arity.zero?` I tried this in the beginning, but that actually only works when not using Sorbet at runtime because Sorbet will always...

> we'll need to keep two code paths around forever Why would archived repos be exempt from deprecation forever?

@dpaoliello, I have given up on `cexpr` since it is way too limited. I have written a replacement ([`cmacro-rs`](https://github.com/reitermarkus/cmacro-rs)) which supports much more complex macros. Sadly no one has reviewed...