Markus Reiter

Thanks for testing, @alex. @emilio, @pvdrz, can you have another look at this?

@pvdrz, @emilio, please have another look here, thank you.

@pvdrz, @emilio, another ping here.

@pvdrz, @emilio, can you have another look at this?

> turn it off by default This is a prerequisite for supporting complex macros (https://github.com/rust-lang/rust-bindgen/pull/2369), so it can't be optional.

@pvdrz, @emilio please have another look. > I'd rather keep the `CXFile` rather than reading the path and doing IO to absolutize it eagerly for most callers that don't need...

Can someone please take a look at this PR? It's been over three months without a review.

Yes, concatenation (`ident ## ident`) as well as stringification (`#ident`) are supported. I think the only problem is Rust's `concat_idents!` does not (yet) support concatenating numbers (i.e. `ident ## 1`).

I think this might actually expand `ONE` to `1 as c_ulong` since there is special treatment for concatenating with a literal suffix like `UL`.

Is should be working now, there was a bug that treated `1 ## U ## LL` different than `1 ## LL # U` which prevented some variants from being parsed.