Richard Reingruber
Richard Reingruber
Thanks for looking at the pr. > Just did a quick scan of the tests. I think it could be good to have both big/small endian tests run on both...
Test error is unrelated to the changes. Upload of test results failed: `Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact`
> @reinrich please ping me again to ask if testing is ok before you integrate ;) Thanks for picking this up again. I quickly wanted to let you know that...
> I'm running testing again, but the code looks good now! > > I just had another idea: Could we use some sort of "byte reverse / shuffle" operation to...
> @reinrich please still wait until the JDK24 fork on Thrusday to integrate, so that we do not have to backport possible regression fixes - I had 3 or 4...
> I did another round of testing on s390x. looks good. Thanks Amit.
What about granting `WXWrite` only if the current thread is in `_thread_in_vm`? That would be more restrictive and roughly equivalent how it currently works. Likely there are some places then...