Richard Reingruber

Results 18 comments of Richard Reingruber

Hi @schmelter-sap, I've marked some older comments as resolved. There are still a bunch open that might be worth addressing though.

> As I wrote in JBS, shouldn't this be handled by `ThreadInVMfromNative`? (I wanted to publish the PR before answering your comment) This would be reasonable in my opinion. I've...

@MBaesken found 2 more locations in jvmti that need switching to `WXWrite` JvmtiExport::get_jvmti_interface GetCarrierThread Both use `ThreadInVMfromNative`.

> > @MBaesken found 2 more locations in jvmti that need switching to `WXWrite` > > ``` > > JvmtiExport::get_jvmti_interface > > GetCarrierThread > > ``` > > Both use...

> > As I wrote in JBS, shouldn't this be handled by `ThreadInVMfromNative`? > > I agree. This is something I am investigating at the moment. Ideally, AssertWXAtThreadSync would also...

> But all this discussion suggests to me that this PR is not really worth pursuing at this time - IIUC no actual failures are observed other than those pertaining...

Tests with AssertWXAtThreadSync are clean now. Thanks! /integrate

@offamitkumar you can put this through your testing if you like. It should solve the issues with test/hotspot/jtreg/compiler/c2/TestMergeStores.java also for s390.

> It's not obvious to me why something like > > ```c++ > a[offset + 2] = (byte)(v >> 16); // Not merged > a[offset + 3] = (byte)(v >>...