Reid Priedhorsky
Reid Priedhorsky
> Anyhow, the approach you suggested does not currently work ([email protected], [email protected]~pre+78aae5e), but I assume that is something for @reidpr ? ``` Command error: ch-run[47171]: error: can't read: /ch/environment: Stale...
Looks like I misunderstood. Thanks for clarifying.
Fantastic, thank you! Do you want us to take it from here, or are you planning more?
We could also just delete the script, maybe replace it with a short-ish FAQ entry.
I propose we do the following. ## General comments / notes * We should specify a version of Pylint we’re targeting. Debian Bullseye e.g. has 2.14 but upstream latest is...
### Class names (C0103 invalid-name) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build_cache.py#L202 We just use a different naming convention. Pylint doesn’t have a pre-configured style name but it should be easy to...
### Log function names (C0103 invalid-name) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/charliecloud.py#L467-L469 These functions just have special names. Probably just add ignore comments to each `def`.
### Bad None comparison (C0121 singleton-comparison) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build_cache.py#L785 Should be `is None`.
### Bad type check? (C0123 unidiomatic-typecheck) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/registry.py#L88-L89 I think this is OK because this class has a weird notion of equality, but needs a little more...
### Bad `range()` (C0200 consider-using-enumerate) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L799-L801 These can be easily refactored to not use indexes.