Reid Priedhorsky

### Non-idiomatic class argument (C0202 bad-classmethod-argument) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build_cache.py#L287-L288 We use `class_` but it’s easy to just change to the idiomatic `cls`.

### Bad `__slots__` (C0205 single-string-used-for-slots) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build_cache.py#L611 These should all be fixed.

### Unnecessary splitting (C0207 use-maxsplit-arg) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L411 This appears to be a performance thing and we don’t use this in places where it matters. I think what...

### Modules too long (C0302 too-many-lines) This probably right, but I don’t see this changing in the foreseeable future and I don’t think Pylint is the right place to enforce...

### Multiple statements per line (C0321 multiple-statements) - [ ] done I don’t mind this and we use it a lot: https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L50 but: https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/image.py#L633-L635 or: https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/image.py#L839-L842 seem confusion-prone. Let’s just...

### Bad import position (C0413 wrong-import-position) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/charliecloud.py#L26-L33 We have a good reason for this, but probably better to disable on a case-by-case basis.

### Inappropriate dunder call (C2801 unnecessary-dunder-call) - [ ] done https://github.com/hpc/charliecloud/blob/5ceefa7040c0accb91acf8b2c99e0f7ec6a97429/lib/filesystem.py#L393 False positive; we’re implementing `os.PathLike`. Suppress case-by-case.

### Bad `except` order (E701 bad-except-order) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/image.py#L751-L759 This is a real bug that should be fixed.

### Nonexistent instance member access in external classes (E1101 no-member) - [ ] done This happens twice: https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build_cache.py#L384-L385 Genuinely wrong and will crash the error message. https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/charliecloud.py#L737 This one seems...

### Non-iterable iterated (E1133 not-an-iterable) - [ ] done https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/registry.py#L118 The specific error is a false positive, but it’s a property that need `@abc.abstractmethod` I think.