regl icon indicating copy to clipboard operation
regl copied to clipboard

Cross browser testing

Open mikolalysenko opened this issue 7 years ago • 10 comments

We need to run regl on some non-v8/ANGLE based systems to make sure everything is still working. At least the following systems should all pass:

  • Firefox (Windows/OS X/ Linux)
  • Safari
  • iOS
  • Android

Maybe browserling would work?

mikolalysenko avatar Jul 27 '16 20:07 mikolalysenko

We should perhaps also support Edge. Some guy on Reddit said that he had been able to run every single shader he'd come across in Edge. But he couldn't run the shadow volumes demo in Edge, for some reason.

Erkaman avatar Aug 04 '16 08:08 Erkaman

We could try using Sauce Labs. It does CI for cross browser testing.

mikolalysenko avatar Sep 11 '16 04:09 mikolalysenko

Debugger.html is using some interesting Firefox-based integration testing. Figured I'd drop it in this issue in case it's helpful. I haven't done as much cross-browser testing, so there could be some other better solutions out there.

gregtatum avatar Dec 22 '16 04:12 gregtatum

I was not able to run the examples from http://regl.party/examples in Edge. Just got a black screen.

danmarshall avatar Jan 04 '18 19:01 danmarshall

@danmarshall could you open the console and provide the error message if there is one?

gregtatum avatar Jan 04 '18 22:01 gregtatum

@gregtatum yes I did that - no errors are reported 😬

danmarshall avatar Jan 04 '18 22:01 danmarshall

@gregtatum - Whoops sorry, there are errors:

in bundle.js line 34994 this.db.createObjectStore(this.storeName, { keyPath: this.keyPath, autoIncrement: this.autoIncrement});

throws InvalidAccessError

danmarshall avatar Jan 04 '18 22:01 danmarshall

#479 makes tests pass in all mentioned browsers, although it takes splitting batches, since not all browsers are comfortable handling 40k assertions.

As for CI solutions I can try to negotiate browserstack to provide an open-source account.

dy avatar May 18 '18 14:05 dy

@danmarshall I think the above traces through browser-module-sandbox, to browser-module-cache, and finally to level.js. In other words, it's the frame that lets you edit code and require node modules rather than an issue with regl. It'd be nice to fix it so that people don't assume regl fails.

rreusser avatar May 18 '18 16:05 rreusser

https://github.com/plotly/plotly.js/pull/2612#issuecomment-391121414

dy avatar May 22 '18 20:05 dy