Eric Leblond
Eric Leblond
I'm playing with one of the available action that handles clang tidy on a subset of the change. On possibility is to create this type of comments on the PR:...
> Would be nice to have the .clang-tidy in file before all fixes and CI is ready. Already finding it useful for my editor. I agree, this is part of...
> Would be nice to get a `Fixes` tag for this, do we know which commit(s) broke it? I did not investigate. I'll try to get that.
> > Would be nice to get a `Fixes` tag for this, do we know which commit(s) broke it? > > I did not investigate. I'll try to get that....
> @regit when do you plan to rework on this ? Hello, I was thinking about reworking this before end of year.
conflict. I'm rebasing.
> > How much of a perf impact is expected if this option is built in but disabled at runtime? > > I have a similar question. I wonder if...
Hello @jasonish, do you need something from me there ?
> Performance-wise, I think things are OK. With my own pcap-based testing, having rule profiling compiled in, but disabled, was not measurable. > > However, compiling it also enabled it...
Implementation proposal in https://github.com/agent0ai/agent-zero/pull/693