suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Mime type reload v2.4

Open regit opened this issue 5 months ago • 1 comments

Update of #13715 addressing comments from @jufajardini. As it seems it was not an in depth review. I'm reproducing here the details of changes from previous PR.

Contribution style:

  • [x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

  • [x] I have updated the User Guide (in doc/userguide/) to reflect the changes made
  • [x] I have updated the JSON schema (in etc/schema.json) to reflect all logging changes (including schema descriptions)
  • [x] I have created a ticket at https://redmine.openinfosecfoundation.org/projects/suricata/issues

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7816

Describe changes:

  • Address comments from @jufajardini
  • Don't embed GPL data by default (it needs to be explicitly set)
  • Load mime type files from disk
  • Embed mime type files in code
  • make install-conf install mime type files
  • make upgrade-data update mime type files

SV_BRANCH=https://github.com/OISF/suricata-verify/pull/2606

regit avatar Aug 17 '25 18:08 regit

Codecov Report

:x: Patch coverage is 83.25581% with 36 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 83.72%. Comparing base (b93a277) to head (f322fa6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13727      +/-   ##
==========================================
+ Coverage   82.99%   83.72%   +0.72%     
==========================================
  Files        1001     1014      +13     
  Lines      272978   275266    +2288     
==========================================
+ Hits       226556   230461    +3905     
+ Misses      46422    44805    -1617     
Flag Coverage Δ
fuzzcorpus 62.92% <63.51%> (+0.04%) :arrow_up:
livemode 19.00% <36.48%> (?)
pcap 44.74% <55.40%> (+0.05%) :arrow_up:
suricata-verify 65.09% <83.98%> (+0.01%) :arrow_up:
unittests 59.17% <56.75%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 17 '25 19:08 codecov[bot]

@regit when do you plan to rework on this ?

catenacyber avatar Dec 17 '25 13:12 catenacyber

@regit when do you plan to rework on this ?

Hello, I was thinking about reworking this before end of year.

regit avatar Dec 17 '25 15:12 regit