regisss

Results 73 comments of regisss

@xyx361100238 The error message says that the model requires 4 inputs but you are providing only 2 of them. Either you need to provide the missing inputs, or you need...

@unography You need to pass the ONNX inputs in the same order as they are registered in the `forward` method of the model. We can see [here](https://github.com/huggingface/transformers/blob/3632531ec60beb03fd3b4f0d30f69853d8bcd5b4/src/transformers/models/clip/modeling_clip.py#L982) that `pixel_values` comes...

@unography Yes, you have to define outputs the same way you did for inputs. Inputs are not defined in the parent class because they usually vary from one model to...

> > @unography Yes, you have to define outputs the same way you did for inputs. Inputs are not defined in the parent class because they usually vary from one...

> @regisss I made the changes, apart from the code formatting. How do I format my code correctly? And do I need to run `make fix-copies` ? I don't think...

@unography Not sure why `modeling_groupvit.py` is still in the changes. Also, can you make sure that the test `pytest tests/onnx/test_onnx_v2.py -v -k "clip"` pass?

> @regisss i reverted changes to groupvit, and when I'm running the test (on Colab) the tests are being skipped - > > ``` > pytest tests/onnx/test_onnx_v2.py -v -k "clip"...

@unography I'm going to checkout your branch and run the test on GPU.

> @regisss do let me know if there are any further changes needed! @unography I had to change two small things in `modeling_clip.py` to make the tests pass: - replace...

Thanks @unography, it looks good to me! Looking at the failed tests, it seems you need to run `make fix-copies` one more time. Could you do it please?