reese-allison

Results 9 comments of reese-allison

I would like to open a PR to implement both of these commented suggestions. I plan to add this to the Search class. ``` def page(self): """ Turn the search...

I opened a PR https://github.com/elastic/elasticsearch-dsl-py/pull/1623

> Any of these methods would help to paginate over the 10000 limit? I regularly use the code on PR #1623 to page millions of objects.

> > I regularly use the code on PR #1623 to page millions of objects. > > Then I am doing something wrong with your code, because an `execute` that...

> While iterating throw the generator, I get such error > > pit = search._using.open_point_in_time( AttributeError: 'str' object has no attribute 'open_point_in_time' Looks like using is set to 'default' >...

> It is good to merge this PR, since iteration with PIT and search_after is widely uses I merged in your suggestions.

Yeah, I suppose it would be good to use search_after to page forward and back rather than just scrolling through all results.

> What will be interesting as well is to add some sort of pagination with search_after and PIT The only way I think this would be possible is if we...

@pquentin, thanks for getting this updated for me! I haven't looked at it in a while.