Sam Reed

Results 294 comments of Sam Reed

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php81/9864/console Looks to be the same result ``` 17:57:10 There were 4 errors: 17:57:10 17:57:10 1) CirrusSearch\DataSenderTest::testSendDeletesRequest with data set "sendDeletes-request-defaults" (array('myfixturewiki', '1ms'), 'content', array('1', '2', '3'), 'dataSender/sendDeletes-reques...pected') 17:57:10 Error:...

Still seems to be broken :( https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1125546/8/ruflin/elastica/src/Bulk.php https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php81/11132/console https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php81/23875/console ``` 13:14:28 There were 4 errors: 13:14:28 13:14:28 1) CirrusSearch\DataSenderTest::testSendDeletesRequest with data set "sendDeletes-request-defaults" (array('myfixturewiki', '1ms'), 'content', array('1', '2', '3'), 'dataSender/sendDeletes-reques...pected')...

It's not the client being null, it's the client being called, having a null connection pool https://github.com/wikimedia/mediawiki-vendor/blob/a4d4ba6/ruflin/elastica/src/Client.php#L407 ``` /** * Determines whether a valid connection is available for use. *...

https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1125546/11/ruflin/elastica/src/Bulk.php Will see what our CI has to say

A different error now - https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-vendor-mysql-php81/2753/console ``` 02:04:52 02:04:52 1) CirrusSearch\DataSenderTest::testSendOtherIndexUpdatesRequest with data set "sendOtherIndexUpdates-request-defaults" (array('myfixturewiki', '1ms'), 'myfixturesourceindex', 'myfixturetargetindex', 2, array(array(1, 'Foo', 0), array(2, 'Bar_baz', 3), array(3, 'Not_Inspired', 2)), 'dataSender/sendOtherIndexUpda...pected')...

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1193372/1/tests/phpunit/integration/DataSenderTest.php actually helps fix the issue for us...

https://github.com/user-attachments/assets/29ed24d7-ca3a-42e2-8820-d1451f8a7b84

While poking around other stuff, the url is similarly pointing to the branch further down too ``` ## See config user guide: https://github.com/openenergymonitor/emonhub/blob/emon-pi/configuration.md ```

Noting this is for the HA documentation... https://github.com/starkillerOG/reolink_aio/blob/fa2b834424952a25fb10c0f3b61195906bb92706/reolink_aio/api.py#L114-L116 ``` # not all chars in a password can be used in the URLS of for instance the FLV stream ALLOWED_SPECIAL_CHARS =...