Reed Hamilton
Reed Hamilton
I believe this issue has been fixed by #8248, closing as complete.
Hello @dcabib, thank you for this large contribution! Before we start looking, could you address the failing `make pr` tests, as well as the github-advanced-security bot's findings? That will make...
Two questions before I review the code: 1. What is the relevance of the issue you linked in the description? 2. ~~What is the intended behavior if a user supplies...
@dcabib I don't think you have pushed any commits adding support for function specific overrides. When you do that, it would also be helpful for future reviewers if this change...
The test failures seem to be flaky and unrelated, I think this is safe to merge.
I can confirm that this is creating new versions each time. This is because the `Publish` flag is set on each iteration of `UpdateFunctionCode`: https://github.com/aws/aws-toolkit-vscode/blob/40ba183dc8a243438c62701f2d13a7a2c22dd7fa/packages/core/src/shared/clients/lambdaClient.ts#L178-L181 Let me confirm if this...
It seems like this is actually an issue in `cfn-lint` (which `sam validate --lint`) is running under the hood. When I ran the latest version of `cfn-lint` (1.42.0 as I...
I am able to reproduce this issue. Examining more.
It looks like the key was rotated automatically, but the documentation was not updated. I have raised this issue with the docs team and will leave this issue open until...
It was rotated 10/21.