Domino Valdano
Domino Valdano
> LGTM! Thanks! Giving @mateusz-sekara one more chance to look at it before it gets merged, in case he still has concerns. If not, will merge this tomorrow.
The code looks fine so far, but instead of here it should go in the `chainlink-solana` repo: https://github.com/smartcontractkit/chainlink-solana/tree/develop/pkg/solana evm is special in that, it's the only relay that's still in...
Giving my approval, with the caveat that I mostly focused on the LogPoller related code and the assumption that others who know the Headtracker / Multinode code better will look...
`pip install ipython-sql` doesn't work on OSX either (for python2). Just noting here, in case someone thinks this is a Linux-specific issue. `pip install ipython-sql==0.3.9` does work though
> Can you please open PRs for the other repos that will need changes so we can review the whole set at once? Ah, I forgot this was still open....
Is this PR still relevant? I notice it has 2 approvals but never got merged 🤔
> > models.Interval > > Are other types used? Or just this one? > > > This moves the chain agnostic db types into chainlink-common > > I think this...
Oh, and it also moves these helper functions from cltest to commontest (`chainlink-common/pkg/utils/tests`), which is needed in order for the tests on the json types to run in chainilnk-common: ```...
> This is not the right place for things common to relays. There will be a common integrations module for that. Oh okay, I didn't realize that. If I recall,...
> The plan was to move chainlink/common to chainlink-integrations/common. I don't know if the location changes now though 🤷 I do remember seeing some things there, come to think of...