chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Replace postgresql 14+ function with postgresql 12 compatible function

Open reductionista opened this issue 1 year ago • 3 comments

This included a function which only works with postgresql 14+, but we must support versions 12-15. Updating with a replacement that will work on 12+

Update: this doesn't use a direct key on the 7 columns in part because that would result in a very large index, and in part because NULL's add some additional complexity anyway. In postgresql 12 & 13, we have to define a helper function for the IMMUTABLE property, in 14 there is a builtin helper to do this.

reductionista avatar Feb 23 '24 05:02 reductionista

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Feb 23 '24 05:02 github-actions[bot]

Does this help? https://github.com/smartcontractkit/chainlink/pull/12155

Yes it does, thank you!

reductionista avatar Feb 23 '24 16:02 reductionista

LGTM!

Thanks! Giving @mateusz-sekara one more chance to look at it before it gets merged, in case he still has concerns. If not, will merge this tomorrow.

reductionista avatar Feb 27 '24 20:02 reductionista