Piotr Szczurkowski

Results 8 comments of Piotr Szczurkowski

This looks promising. I will have to write an example implementation to your functionality to test if it even works as it should.

Okay, i tried implementing a POC into my DFU bootloader project using your proposed branch. Something seems off because DFU (i think) should check couple of alt settings when listing...

Oh okay, that makes much more sense. Will correct this and hopefully it will work now :) > @redpfire You only seem to write one alt setting descriptor: https://github.com/redpfire/dfu-boot/blob/c56c1fcc6f33c3d02767a5a0acd00264b8ca73cb/src/dfu.rs#L203 >...

Okay, calling `interface_alt` for every alt setting indeed worked. I also implemented an interface check. https://github.com/redpfire/dfu-boot/blob/739e0a7e665c1e1aa270dfdba34e1721fa6aa96e/src/dfu.rs#L203 Output from dfu-util is as expected: ``` dfu-util 0.10 Copyright 2005-2009 Weston Schmidt, Harald...

@Sawchord waiting for you to commit changes mentioned in the review :) Also please squash all the commits into one meaningful commit for a cleaner merge.

Yep, still works. Nice work!

Hi! Sorry for late response, I've pretty much abandoned the project and haven't been looking at it since then. The thing is - I tried to provide Windows binary but...

Thank you! I'll try building it in my free time sometime this week.