Roman Edirisinghe
Roman Edirisinghe
@BradMcGonigle, since you're not setting `#skrollr-body` on the body tag, you'd need to test the `` instead of the ``. To do this, it would make sense to have a...
@sambapete can you be more specific about which translation was incorrect? Note: There is no `learning.outline.alert.start.long`, but there is a `learning.outline.alert.start.short`.
Hi @sambapete I was trying to point out that none of the translation json files reference that variable name. For example, see https://github.com/openedx/frontend-app-learning/blob/master/src/i18n/messages/de.json#L9-L10 Check some of the other translation files...
@sambapete Ah, gotcha. Thanks for clarifying!
@bradenmacdonald thoughts?
> @rediris Can you please provide more context for this change, as well as screenshots, etc? > > I'm not sure I fully understand this, but if my assumptions are...
@kdmccormick I haven't yet received the DocuSign from what I can see.
> @rediris Don't worry about rebasing. Your change is tiny, so it doesn't matter if it's a few dozen commits out of date. OK, thanks for the info. I'll keep...
> Code still looks good. Hopefully you've been able to find that email @rediris ? Hi, yes, I finally found the email and will get the appropriate people to respond....