openedx
fix: remove duplicate (unclosed) tag
Description
This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source.
See original, abandoned PR here: https://github.com/openedx/edx-platform/pull/35301
Thanks for the pull request, @rediris!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Submit a signed contributor agreement (CLA)
:warning: We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation. Please see the CONTRIBUTING file for more information.
If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.
Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
@mphilbrick211 , on his old PR @rediris had said:
I did send a CLA request, but I don't know where I am in the process. I'm going to scrap this PR and start over - this rebasing is turning into too much of a headache.
do you know if his CLA is stuck?
@rediris Don't worry about rebasing. Your change is tiny, so it doesn't matter if it's a few dozen commits out of date.
@rediris Don't worry about rebasing. Your change is tiny, so it doesn't matter if it's a few dozen commits out of date.
OK, thanks for the info. I'll keep this PR as is.
@rediris Don't worry about rebasing. Your change is tiny, so it doesn't matter if it's a few dozen commits out of date.
OK, thanks for the info. I'll keep this PR as is.
@rediris it looks like our legal counsel, Nell Ma'luf, sent you an email requesting more information on August 15. Did you receive it? I'm not sure if you responded or not. If you've already responded, let me know and I'll look further into it.
Code still looks good. Hopefully you've been able to find that email @rediris ?
Hi, yes, I finally found the email and will get the appropriate people to respond. Meanwhile, would it be be helpful for me to re-submit this using my personal github profile rather than the gymnasium business profile? I think signing a personal CLA would be considerably faster.