Michael D Johnson

Results 18 comments of Michael D Johnson

I personally like the idea of just passing the value into the function for e.g. `map()`. However, I have had occasion to use the index and collection in the past....

I don't know if I like the idea of changing parameter order. To me personally, the order seems correct. It's closest to `$collection->map(function () { /* ... */ })`. I'd...

@lstrojny, a conversion tool would help a lot. Would you want to create one from scratch or do something like a fixing sniff for [PHP_CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer)?

I don't have reproduce code but can say it happens to me without semantic-php. I am running flycheck with PHPCS and PHPMD, but I'm pretty sure I had this problem...

Yes, a `.dist` file isn't parsed. And then there is no actual config file that ships, because we shouldn't overwrite an existing config file.

Out of curiosity, why is the default file a dot file? I think I'd prefer to see it as an always-visible file.

I haven't tested everything out, but the code looks good. Presuming it all works, :+1:

My only thought is it should mirror the error suppression annotations from #52.

It looks good to me. I also prefer JSON. But Any format is fine as long as it's consistent.

I have some older projects that used `.inc`. I believe at the time it was a fairly common practice. Of course, that was PHP 4 when I was able to...