Réda Housni Alaoui

Results 192 comments of Réda Housni Alaoui

Here is how I did it with dynamic imports: ```javascript let inject = (lang) => tmhDynamicLocaleCache.put(lang, angular.injector(['ngLocale']).get('$locale')); $q.all([ System.import('angular-i18n/angular-locale_de') .then(() => inject('de')), System.import('angular-i18n/angular-locale_en') .then(() => inject('en')), System.import('angular-i18n/angular-locale_es') .then(() => inject('es')),...

1. Have you implemented it as proposed [here](https://github.com/uwolfer/gerrit-intellij-plugin/issues/159#issuecomment-183383332)? Almost. In addition to the aforementioned comment, I moved settings "CloneBaseUrl" to project settings level. However, I didn't touch the ui. I...

Whitespaces/indentation changes were removed

I tried to do that at first. But I came to the conclusion that settings like the ones adding grid columns should be global. Most of the time, you want...

> I tried to do that at first. But I came to the conclusion that settings like the ones adding grid columns should be global. Most of the time, you...

We could also consider that all settings should be project level because IntelliJ encourages it. From this point of view, we can consider that the poor ergonomics is IntelliJ's fault,...

In this case, I prefer to keep it simple for this PR ;) Once this is merged, I will move pushToGerritByDefault to the project level.

@uwolfer ok I will try that asap

@uwolfer I locally rebased on intellij2016.2 . I have no error while saving the settings. Could you tell me what you do exactly so that I try to reproduce? The...

@uwolfer Ok I will. Sorry I didn't have much time lately.