red031000
red031000
this is already not consistent in the code we have, but imo MULCH_MAX is the way to go here
length imo, considering stuff like player name sounds a lot better being PLAYER\_NAME_LENGTH etc
LENGTH better imo, really dont like abbreviations when there's no reason to
I don't mind NUM_MULCHES and MULCHES_MAX for the hardware limit
1. no 2. yes 3. yes 4. no 5. yes this is mostly making exceptions to save stuff, and changing it would be a lot of work but, if it's...
as for `Encounter_GetResult` vs `GetEncounterResult` we have gradually be leaning more towards the former, but there are many examples of the latter still around, as for which one is preferred...
EOS is a chunsoft game so it's possible (and likely) that things are not done in the same class-esque structure as the main series games
what's the difference?
imo no underscore in unknown fields, again this is already in the style guide, I just haven't gone through and fixed it all yet
if this isn't ready pls mark as draft