common
common copied to clipboard
readthedocs
Shared bits around multiple repositories
Currently our pre-commit settings for prospector doesn't really work well. Can't be re-used in .com, we had to disable that check https://github.com/readthedocs/readthedocs-corporate/pull/1698. The reason it fails is because of two...
We may want to generalize the implementation I've done in addons and share it with other projects. See https://github.com/readthedocs/addons/pull/116#pullrequestreview-1617933134
In theory, `nodemon` should watch only 779, ``` root@716db483de08:/usr/src/app/checkouts/readthedocs.org# find ./readthedocs -type f -name '*.py' | wc -l 779 ``` but it says it's watching ~5k: ``` web_1 | [nodemon]...
References ISSUE - https://github.com/readthedocs/readthedocs.org/issues/7761 PR - https://github.com/readthedocs/readthedocs.org/pull/8708
Refers [Issue - 9332](https://github.com/readthedocs/readthedocs.org/issues/9332)
In #144, we moved the configuration of MinIO storage bucket policies to a process related to initialize the `web` container. This was a kind "configuration as code" chosen over the...
A neat idea was brought up in a theme PR: https://github.com/readthedocs/sphinx_rtd_theme/pull/822 It would replace code that we have for loading the version from setup.cfg perhaps, but would also replace the...
We shouldn't require this anymore now that we are running the `git` commands inside the Docker container. This mount could probably removed completely: https://github.com/readthedocs/common/blob/master/dockerfiles/docker-compose.yml#L110 Allows to avoid `VersionLocked` exception when...
A couple of small changes that surfaced linting the entire readthedocsinc codebase: * No need for utf8 header in files anymore * https://github.com/rtfd/readthedocs-corporate/pull/463/files/5c179ca89339adb3c59d43ab8cc36044f1146708..2f9f47fc69fb2df467f4f17261cf8613850f3d7a#diff-b48d75844df80305a816a632c69f63fd * https://github.com/rtfd/readthedocs-corporate/pull/463/files/5c179ca89339adb3c59d43ab8cc36044f1146708..2f9f47fc69fb2df467f4f17261cf8613850f3d7a#diff-9bb2189bdb7f183f9a7f6731866b3677
See discussion here: https://github.com/rtfd/common/pull/4#discussion_r181123662 Raised in #4