Ryan Blue
Ryan Blue
@xloya, can you separate backports into individual PRs, please?
@jzhuge, I just had a look at this and it's mostly good. I think a few places should be updated though. Can you make the changes? Thanks!
Rather than running these along with unit tests, what about adding a configuration to run them separately? Would that be annoying to have so many checks? It would hopefully make...
10 seconds sounds reasonable to me. No need to move them out, then.
I'm -1 on this. Not removing the backup table is intentional so that the user could choose which table to move forward with. Our docs included a step to "remove...
It should be easy to add a flag to do this check. The default behavior is this way because this was implemented without namespace support initially.
This mostly looks good, but there are some unnecessary behavior changes to fix. Thanks, @ConeyLiu!
@felixYyu can you please add some information about your approach to the PR description?
@felixYyu, I was asking for you to describe the problem and the proposed solution that you've implemented here. I don't see much information about the solution you propose. Could you...
The intent here was to refer to the function defined for the `int` type. It looks like people are confusing these functions with hash specific methods in the hash implementation....